This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
ci: add semantic.yml for commit linting, update PR template to latest #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iain Anderson <iain@iotechsys.com>
lenny-goodell
suggested changes
Dec 10, 2020
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] Documentation content changes | ||
| - [ ] Other... Please describe: | ||
|
|
||
| **If your build fails** due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/master/.github/CONTRIBUTING.md |
There was a problem hiding this comment.
This should point to device-grove-c's CONTRIBUTING.md
There was a problem hiding this comment.
ah yes, attack of the copypastes
Signed-off-by: Iain Anderson <iain@iotechsys.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Iain Anderson iain@iotechsys.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
What is the new behavior?
Enforce conventional commits and include latest PR template and Contributing file
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information