This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
ci: standardize dockerfiles #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestojeda
added
ci
ernestojeda
requested review from
soda480,
jamesrgregg,
lenny-goodell and
bill-mahoney
ernestojeda
force-pushed
the
devops-std-dockerfiles
branch
2 times, most recently
from
0b11e6e
to
70f5f2b
Compare
- [x] use alpine 3.12 - [x] common `apk add` where possible - [x] update copyright header where possible Signed-off-by: Ernesto Ojeda <ernesto.ojeda@intel.com>
ernestojeda
force-pushed
the
devops-std-dockerfiles
branch
from
70f5f2b
to
0625bb8
Compare
soda480
approved these changes
Jan 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apk addwhere possibleI am renaming the Dockerfile's here to be more consistent with the rest of the projects. Also as we upgrade alpine we will not have to keep renaming files and having to update the Jenkinsfile.
Signed-off-by: Ernesto Ojeda ernesto.ojeda@intel.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-grove-c/blob/master/.github/CONTRIBUTING.md
What is the current behavior?
Issue Number: #56
What is the new behavior?
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Other information