Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

build: take new csdk release #59

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

iain-anderson
Copy link
Member

  • CSDK 1.3.1
  • update makefile for new Dockerfile location

Signed-off-by: Iain Anderson iain@iotechsys.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-grove-c/blob/master/.github/CONTRIBUTING.md

What is the current behavior?

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Other information

BinduRao2018
BinduRao2018 previously approved these changes Jan 25, 2021
Copy link
Contributor

@BinduRao2018 BinduRao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Observation not related to this ticket:
Require an update to the build instruction in Readme to use Dockerfile.alpine. Could this be done as part of this PR?

* update makefile and README for new Dockerfile location

Signed-off-by: Iain Anderson <iain@iotechsys.com>
@iain-anderson
Copy link
Member Author

Yes, added README update to the commit

Copy link
Contributor

@BinduRao2018 BinduRao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BinduRao2018 BinduRao2018 merged commit 282b5d3 into edgexfoundry:master Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants