Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

fix: use new port assignments (#65), standardise service name (#66) #67

Merged
merged 1 commit into from
May 26, 2021

Conversation

iain-anderson
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-grove-c/blob/master/.github/CONTRIBUTING.md

What is the current behavior?

  1. Service uses old port assignments (48xxx, 49xxx)
  2. Default service name is mixed-case

Issue Number: #65 #66

What is the new behavior?

New port assignments (598xx, 599xx)
Service name is device-grove

Does this PR introduce a breaking change?

  • Yes
  • No

Reconfiguration required for clients using old port numbers

New Imports

  • Yes
  • No

Specific Instructions

Scripting in test/ directory still harbors old port numbers; however this needs to be reworked in any case as export-client is no longer supported

Other information

fix: standardise service name (edgexfoundry#66)

Signed-off-by: Iain Anderson <iain@iotechsys.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants