-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add command line/environment flag for commonConfig #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixTing
changed the title
Common config flag
feat: Add command line/environment flag for commonConfig
Sep 27, 2023
lenny-goodell
requested changes
Sep 27, 2023
FelixTing
force-pushed
the
common-config-flag
branch
from
September 28, 2023 03:27
fd31eaa
to
a5208ef
Compare
FelixTing
force-pushed
the
common-config-flag
branch
5 times, most recently
from
October 6, 2023 04:19
70bec12
to
fce8b44
Compare
FelixTing
force-pushed
the
common-config-flag
branch
from
October 6, 2023 04:42
fce8b44
to
4caea52
Compare
Signed-off-by: FelixTing <felix@iotechsys.com>
FelixTing
force-pushed
the
common-config-flag
branch
from
October 8, 2023 02:15
4caea52
to
ca04866
Compare
iain-anderson
approved these changes
Oct 9, 2023
Hi @lenny-intel, this PR cannot be merged due to the change request. Could you please approve this PR if you are happy with the changes? |
lenny-goodell
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #485
Hold until #484 is merged
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Non-secure mode testing
make run no-secty
.export EDGEX_SECURITY_SECRET_STORE=false
-cc=../commonconfiguration.yaml
argument.Secure mode testing
make run
.export EDGEX_SECURITY_SECRET_STORE=true
-cc=../commonconfiguration.yaml
argument.New Dependency Instructions (If applicable)