fix: Use deepCopy of messageBusInfo to avoid external adds #1167

jinlinGuan · 2022-05-25T03:16:53Z

Signed-off-by: Ginny Guan ginny@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
I am not introducing a new dependency (add notes below if you are)
I have added unit tests for the new feature or bug fix (if not, why?) update the existing unit test
I have fully tested (add details below) this the new feature or bug fix (if not, why?)
I have opened a PR for the related docs change (if not, why?)

fix edgexfoundry#1160 Signed-off-by: Ginny Guan <ginny@iotechsys.com>

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

closes edgexfoundry#1090 Signed-off-by: Chris Hung <chris@iotechsys.com>

lenny-goodell

LGTM, just have a couple questions.

internal/controller/http/common_test.go

internal/telemetry/linux_cpu.go

jinlinGuan and others added 3 commits May 25, 2022 10:43

fix: Use deepCopy of messageBusInfo to avoid external adds

77f757b

fix edgexfoundry#1160 Signed-off-by: Ginny Guan <ginny@iotechsys.com>

build: Updated formatting from gofmt 1.17

c48eeeb

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

fix: update TestMetricsRequest to not fail when using -race

78ece4d

closes edgexfoundry#1090 Signed-off-by: Chris Hung <chris@iotechsys.com>

lenny-goodell approved these changes May 25, 2022

View reviewed changes

internal/controller/http/common_test.go Show resolved Hide resolved

internal/telemetry/linux_cpu.go Show resolved Hide resolved

lenny-goodell merged commit 6b28ab1 into edgexfoundry:jakarta May 25, 2022

jinlinGuan deleted the issue-1160 branch May 26, 2022 04:39