Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CBOR library for security #473

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

chr1shung
Copy link

Fix #471
Signed-off-by: Chris Hung chris@iotechsys.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #473 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   55.77%   55.77%           
=======================================
  Files          24       24           
  Lines        2415     2415           
=======================================
  Hits         1347     1347           
  Misses        970      970           
  Partials       98       98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a3efc...d827b43. Read the comment docs.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use go-mod-core-contracts v0.1.54 to make sure the CBOR library consistent

Signed-off-by: Chris Hung <chris@iotechsys.com>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit b92b1a4 into edgexfoundry:master Apr 8, 2020
@chr1shung chr1shung deleted the issue-471 branch April 8, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch CBOR library to fxamacker/cbor for security reasons
3 participants