-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CBOR library for security #473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
=======================================
Coverage 55.77% 55.77%
=======================================
Files 24 24
Lines 2415 2415
=======================================
Hits 1347 1347
Misses 970 970
Partials 98 98 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use go-mod-core-contracts v0.1.54 to make sure the CBOR library consistent
Signed-off-by: Chris Hung <chris@iotechsys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #471
Signed-off-by: Chris Hung chris@iotechsys.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?