Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to correctly support -r argument #478

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

chr1shung
Copy link

@chr1shung chr1shung commented Apr 9, 2020

Fixes #477
Fixes #217

Signed-off-by: Chris Hung chris@iotechsys.com

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #478 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   55.63%   55.63%           
=======================================
  Files          24       24           
  Lines        2421     2421           
=======================================
  Hits         1347     1347           
  Misses        974      974           
  Partials      100      100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d36f33...6677092. Read the comment docs.

Signed-off-by: Chris Hung <chris@iotechsys.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 1bb097a into edgexfoundry:master Apr 10, 2020
@chr1shung chr1shung deleted the issue-477 branch April 10, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--registry not working properly Unregister from Registry when the Device Service stops
4 participants