Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support read operation of binary resource #82

Closed
wants to merge 1 commit into from
Closed

Support read operation of binary resource #82

wants to merge 1 commit into from

Conversation

FelixTing
Copy link
Member

close #42

Signed-off-by: Felix Ting felix@iotechsys.com

@FelixTing
Copy link
Member Author

wait for edgex-go #2272 to be resolved

@akramtexas akramtexas mentioned this pull request Jan 21, 2020
Closed
@FelixTing
Support read operation of binary resource
fe11fc8 
Signed-off-by: Felix Ting <felix@iotechsys.com>
@FelixTing FelixTing marked this pull request as ready for review February 27, 2020 09:12
cloudxxx8
cloudxxx8 reviewed Mar 8, 2020
View reviewed changes
internal/driver/virtualdriver.go
b := make([]byte, dsModels.MaxBinaryBytes)
rand.Seed(time.Now().UnixNano())
rand.Read(b)
dr.Properties.Value.DefaultValue = hex.EncodeToString(b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using dr.Properties.Value.DefaultValue instead of a new variable here?

@cloudxxx8
Copy link
Member

please handle the check error

[2020-02-27T06:30:44.281Z] + make test
[2020-02-27T06:30:44.281Z] CGO_ENABLED=0 GO111MODULE=on go test ./... -coverprofile=coverage.out
[2020-02-27T06:30:46.192Z] ? github.com/edgexfoundry/device-virtual-go [no test files]
[2020-02-27T06:31:04.370Z] ? github.com/edgexfoundry/device-virtual-go/cmd [no test files]
[2020-02-27T06:35:56.150Z] ok github.com/edgexfoundry/device-virtual-go/internal/driver 278.583s coverage: 51.3% of statements
[2020-02-27T06:35:56.150Z] CGO_ENABLED=0 GO111MODULE=on go vet ./...
[2020-02-27T06:35:56.150Z] gofmt -l .
[2020-02-27T06:35:56.150Z] [ "gofmt -l ." = "" ]
[2020-02-27T06:35:56.150Z] ./bin/test-attribution-txt.sh
[2020-02-27T06:35:56.150Z] An attribution for github.com/OneOfOne/xxhash is missing from in Attribution.txt, please add
[2020-02-27T06:35:56.150Z] An attribution for github.com/jessevdk/go-flags is missing from in Attribution.txt, please add
[2020-02-27T06:35:56.150Z] make: *** [Makefile:27: test] Error 1
script returned exit code 2

@FelixTing
Copy link
Member Author

re-create this PR using personal GitHub account

@FelixTing FelixTing closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CBOR data type support in Virtual Device
2 participants
@FelixTing @cloudxxx8