Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query variable in share dashboard url [enhancement] #1796

Closed
LilyBlooper opened this issue Jun 11, 2020 · 2 comments
Closed

Support query variable in share dashboard url [enhancement] #1796

LilyBlooper opened this issue Jun 11, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@LilyBlooper
Copy link

In real scenarios , the system which davinci share dashboard was embedded to usually has individual RBAC-based auth model . So we embed share dashboard only using query variables。

now (dev-0.3) , one can only apply a dynamic query param using "global control " in dashboard .
We usually need the query params interchangable with query variable.

image

In query variable configuration during view settings . A query variable could be chosen as string with multiple default values , while in url param , the value cound only be “single” 。

For example :
This is a mock project 。The project has multiple menus , each menus was authorized to certain roles . The role and auth mode was provided in the project itself 。 So Davinci's organization and role model will not be used .
image

image

Here we need to pass the query param with multiple values 。
One menu will link http://davinci3/share.html#shareInfo=aaaaaaa&type=dashboard&var_domain_in=foo,bar,baz
Other menu will link
http://davinci3/share.html#shareInfo=aaaaaaa&type=dashboard&var_domain_in=another,yetanother

we expect the params will overwrite the default values set in view .
This enhancement will really useful in many cases 。

@scottsut
Copy link
Member

We now support multiple params format like &var_domain_in[0]=foo&var_domain_in[1]=bar. However, in some environments, nginx will treat the square brackets as illegal characters, so we gonna support the basic format like &var_domain_in=foo&var_domain_in=bar in the near future.

@scottsut scottsut added the bug label Jun 11, 2020
@scottsut scottsut added this to the 0.3 milestone Jun 11, 2020
@ruanhan
Copy link
Member

ruanhan commented Jun 15, 2020

now support multiple params format like &a=1&a=2&a=3 in origin/dev-0.3

ruanhan added a commit to ruanhan/davinci that referenced this issue Jun 15, 2020
scottsut added a commit that referenced this issue Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants