Fix: set effective byte order of FT copy _and_ original #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bt_ctf_trace_add_stream_class() and bt_ctf_stream_class_add_event_class(), it is possible that field types are copied for length/tag field type resolving purposes (we cannot keep the same sequence field type reference at different locations within the metadata tree because then the resolved length field type would be the same reference). However, the effective byte order is set on the copied field types. If the user keeps an original field type reference, then its byte order remains unset and the user can still create a field from this field type. This means that the field serialization function reads a wrong effective byte order, possibly leading to a corrupted stream file. This patch makes bt_ctf_trace_add_stream_class() and bt_ctf_stream_class_add_event_class() set the effective byte order of the original field types too. Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
|
Cool, I tried this out on my test and it does fix my problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.