Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript definitions #3

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add Typescript definitions #3

merged 1 commit into from
Mar 6, 2020

Conversation

electrovir
Copy link
Contributor

@electrovir electrovir commented Mar 6, 2020

This resolves #2

Simple solution which is mostly just a copy paste straight from the README. Comments included.

  • I have read the contribution guidelines.
  • I have added tests (we are enforcing 100% test coverage).
    • Not sure how to add tests for this.
  • I have added documentation in the README.md, the docs directory (if
    any) and the examples directory (if any).
    • Also not sure exactly what to document, if anything, in the README about this.
  • The status checks are successful (continuous integration). Those can be
    seen below.

@electrovir
Copy link
Contributor Author

Should I update .all-contributorsrc?

@electrovir
Copy link
Contributor Author

Example type tips rendered in VS Code:

Screen 2020-03-05 at 8 01 44 PM
Screen 2020-03-05 at 8 02 18 PM

Copy link
Owner

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @electrovir!

Looks good to me overall. There are just few minor tweaks :)

You're right: no need for tests nor documentation.

package.json Outdated Show resolved Hide resolved
src/main.d.ts Outdated Show resolved Hide resolved
src/main.d.ts Outdated Show resolved Hide resolved
@ehmicky
Copy link
Owner

ehmicky commented Mar 6, 2020

@all-contributors could you please add @electrovir for adding this code?

@allcontributors
Copy link
Contributor

@ehmicky

I've put up a pull request to add @electrovir! 🎉

@ehmicky ehmicky self-requested a review March 6, 2020 13:52
@ehmicky ehmicky merged commit 152d187 into ehmicky:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typings for imports in Typescript
2 participants