Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new directory-style templates for issues and PRs #9

Merged

Conversation

magnusbaeck
Copy link
Member

Applicable Issues

Fixes #8

Description of the Change

This'll make it easy to have multiple issue templates (and PR templates, but they take more work to use) should we e.g. want to have separate templates for bug reports and feature requests.

Alternate Designs

None.

Benefits

Enabler for having multiple templates. Even if we don't want multiple templates in this repository, using the directory-style templates here will make it easier to synchronize them with the template directories of other repositories. Unfortunately templates in the .github repo aren't merged with the templates in another repository.

Possible Drawbacks

None.

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Magnus Bäck <magnus.back@axis.com>

This'll make it easy to have multiple issue templates (and PR templates,
but they take more work to use) should we e.g. want to have separate
templates for bug reports and feature requests.
@magnusbaeck magnusbaeck merged commit 8424091 into eiffel-community:master Aug 19, 2021
@magnusbaeck magnusbaeck deleted the dir-style-templates branch August 19, 2021 09:53
@magnusbaeck
Copy link
Member Author

It turns out changing the template to the directory-style template also displays the issue type page (below) when you click the New Issue button even though there's only one template. That's a bit annoying but probably something we can live with.

image

@m-linner-ericsson
Copy link
Member

We can live with it and in the future, we might want to add more. Bug reports and feature requests are different types of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate templates for issues and PRs to new style
4 participants