Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ethereum RPC call "eth_blockByNumber" #128

Merged
merged 3 commits into from
Jan 8, 2023

Conversation

enitrat
Copy link
Contributor

@enitrat enitrat commented Dec 19, 2022

Implements the eth_blockByNumber RPC endpoint support

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: #84

What is the new behavior?

API endpoint /ethereum/get_block_by_number/<block>/<full_tx>, CLI command query-block-by-number, beerus core command implementation and tests for eth_getBlockByNumber

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

Codecov Report

Base: 87.66% // Head: 87.19% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (0745cac) compared to base (f677e75).
Patch coverage: 75.38% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   87.66%   87.19%   -0.47%     
==========================================
  Files          23       23              
  Lines        1637     1702      +65     
==========================================
+ Hits         1435     1484      +49     
- Misses        202      218      +16     
Impacted Files Coverage Δ
...ore/src/lightclient/ethereum/helios_lightclient.rs 20.33% <0.00%> (-3.67%) ⬇️
beerus_core/src/lightclient/ethereum/mod.rs 100.00% <ø> (ø)
beerus_cli/src/model.rs 62.92% <50.00%> (-1.28%) ⬇️
beerus_rest_api/src/api/ethereum/endpoints.rs 93.92% <90.32%> (-0.75%) ⬇️
beerus_cli/src/ethereum/mod.rs 100.00% <100.00%> (ø)
beerus_cli/src/runner.rs 84.05% <100.00%> (+0.98%) ⬆️
beerus_rest_api/src/api/ethereum/resp/mod.rs 100.00% <100.00%> (ø)
beerus_rest_api/src/lib.rs 91.66% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danilowhk danilowhk enabled auto-merge (rebase) December 29, 2022 13:22
@danilowhk
Copy link
Contributor

Lgtm :)

beerus_cli/Cargo.toml Outdated Show resolved Hide resolved
auto-merge was automatically disabled January 8, 2023 17:32

Head branch was pushed to by a user without write access

@danilowhk danilowhk enabled auto-merge (squash) January 8, 2023 21:58
@danilowhk danilowhk enabled auto-merge (squash) January 8, 2023 21:58
@danilowhk danilowhk merged commit 90ac0b9 into eigerco:main Jan 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants