Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Starknet "get_block_with_txs" #167

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

danilowhk
Copy link
Contributor

  • Added get_block_with_txs at CLI command.
  • Added a new endpoint to fetch the block data and the txs on the Starknet Network
  • Implemented tests for Cli, Core and RestAPI
  • Updated ethers library

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 84.13% // Head: 86.32% // Increases project coverage by +2.19% 🎉

Coverage data is based on head (1e7c5d1) compared to base (84d9824).
Patch coverage: 82.75% of modified lines in pull request are covered.

❗ Current head 1e7c5d1 differs from pull request most recent head ff4e73e. Consider uploading reports for the commit ff4e73e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   84.13%   86.32%   +2.19%     
==========================================
  Files          23       23              
  Lines        2855     2121     -734     
==========================================
- Hits         2402     1831     -571     
+ Misses        453      290     -163     
Impacted Files Coverage Δ
beerus_core/src/lightclient/starknet/mod.rs 42.68% <0.00%> (+13.27%) ⬆️
beerus_cli/src/model.rs 56.09% <50.00%> (+0.23%) ⬆️
beerus_cli/src/runner.rs 86.73% <88.88%> (-1.09%) ⬇️
beerus_rest_api/src/api/starknet/endpoints.rs 94.84% <96.00%> (+1.51%) ⬆️
beerus_cli/src/starknet/mod.rs 85.47% <100.00%> (-6.16%) ⬇️
beerus_rest_api/src/api/starknet/resp/mod.rs 100.00% <100.00%> (+15.38%) ⬆️
beerus_rest_api/src/lib.rs 93.02% <100.00%> (-0.98%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danilowhk danilowhk force-pushed the rpc_starknet_get_block_with_txs branch from 782cd91 to ff4e73e Compare January 16, 2023 23:28
@danilowhk danilowhk merged commit d33f2c7 into eigerco:main Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants