Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Starknet "add_invoke_transaction" #175

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

danilowhk
Copy link
Contributor

@danilowhk danilowhk commented Jan 13, 2023

  • Added add_invoke_transaction CLI command.
  • Added a new endpoint to add a invoke transaction on Starknet Network
  • Implemented tests for Cli, Core and RestAPI
  • Updated ethers library

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: #160

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 84.72% // Head: 84.97% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (20e211c) compared to base (a4f99d6).
Patch coverage: 86.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   84.72%   84.97%   +0.25%     
==========================================
  Files          23       23              
  Lines        2455     2576     +121     
==========================================
+ Hits         2080     2189     +109     
- Misses        375      387      +12     
Impacted Files Coverage Δ
beerus_core/src/lightclient/starknet/mod.rs 37.23% <0.00%> (-3.95%) ⬇️
beerus_cli/src/model.rs 60.75% <25.00%> (+0.11%) ⬆️
beerus_cli/src/runner.rs 87.40% <94.11%> (+1.03%) ⬆️
beerus_rest_api/src/api/starknet/endpoints.rs 95.26% <98.00%> (+0.44%) ⬆️
beerus_cli/src/starknet/mod.rs 89.30% <100.00%> (+3.47%) ⬆️
beerus_rest_api/src/api/starknet/resp/mod.rs 100.00% <100.00%> (ø)
beerus_rest_api/src/lib.rs 93.61% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danilowhk danilowhk merged commit 605b125 into eigerco:main Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants