[code] Rename sentenceBack to sentencePrevious

Co-authored-by: Ali Caglayan <alizter@gmail.com>
ejgallego · May 17, 2024 · fc47d40 · fc47d40
1 parent ff1f159
commit fc47d40
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -75,8 +75,8 @@
  - new VSCode commands to allow to move one sentence backwards /
    forward, this is particularly useful when combined with lazy
    checking mode (@ejgallego, #671, fixes #263, fixes #580)
- - VSCode commands `coq-lsp.sentenceNext` / `coq-lsp.sentenceBack` are
-   now bound by default to `Alt + N` / `Alt + P` keybindings
+ - VSCode commands `coq-lsp.sentenceNext` / `coq-lsp.sentencePrevious`
+   are now bound by default to `Alt + N` / `Alt + P` keybindings
    (@ejgallego, #718)
  - change diagnostic `extra` field to `data`, so we now conform to the
    LSP spec, include the data only when the `send_diags_extra_data`
@@ -142,7 +142,7 @@
    restart. This fixes some bugs on extension restart (finally!)
    (@ejgallgo, #719)
  - Center the view if cursor goes out of scope in
-   `sentenceNext/sentenceBack` (@ejgallego, #718)
+   `sentenceNext/sentencePrevious` (@ejgallego, #718)
 
 # coq-lsp 0.1.8.1: Spring fix
 -----------------------------

diff --git a/editor/code/package.json b/editor/code/package.json
@@ -111,7 +111,7 @@
         "title": "Coq LSP: try to jump to next Coq sentence"
       },
       {
-        "command": "coq-lsp.sentenceBack",
+        "command": "coq-lsp.sentencePrevious",
         "title": "Coq LSP: try to jump to previous Coq sentence"
       },
       {
@@ -133,7 +133,7 @@
         "when": "editorTextFocus && (editorLangId == coq || editorTextFocus && editorLangId == markdown)"
       },
       {
-        "command": "coq-lsp.sentenceBack",
+        "command": "coq-lsp.sentencePrevious",
         "key": "Alt+P",
         "mac": "cmd+P",
         "when": "editorTextFocus && (editorLangId == coq || editorTextFocus && editorLangId == markdown)"

diff --git a/editor/code/src/client.ts b/editor/code/src/client.ts
@@ -45,7 +45,7 @@ import { CoqLspClientConfig, CoqLspServerConfig, CoqSelector } from "./config";
 import { InfoPanel, goalReq } from "./goals";
 import { FileProgressManager } from "./progress";
 import { coqPerfData, PerfDataView } from "./perf";
-import { sentenceNext, sentenceBack } from "./edit";
+import { sentenceNext, sentencePrevious } from "./edit";
 import { HeatMap, HeatMapConfig } from "./heatmap";
 import { debounce, throttle } from "throttle-debounce";
 
@@ -461,7 +461,7 @@ export function activateCoqLSP(
   coqEditorCommand("save", saveDocument);
 
   coqEditorCommand("sentenceNext", sentenceNext);
-  coqEditorCommand("sentenceBack", sentenceBack);
+  coqEditorCommand("sentencePrevious", sentencePrevious);
 
   coqEditorCommand("heatmap.toggle", heatMapToggle);
 

diff --git a/editor/code/src/edit.ts b/editor/code/src/edit.ts
@@ -17,7 +17,7 @@ function setSelection(editor: TextEditor, newCursor: Position) {
   );
 }
 
-export function sentenceBack(editor: TextEditor) {
+export function sentencePrevious(editor: TextEditor) {
   // Slice from the beginning of the document
   let cursor = editor.selection.active;
   let range = new Range(editor.document.positionAt(0), cursor);

diff --git a/etc/doc/USER_MANUAL.md b/etc/doc/USER_MANUAL.md
@@ -48,9 +48,9 @@ facilities. In VSCode, these settings can be usually displayed in the
 By default, `coq-lsp` will follow cursor and show goals at cursor
 position. This can be tweaked in options.
 
-The `coq-lsp.sentenceNext` and `coq-lsp.sentenceBack` commands will
+The `coq-lsp.sentenceNext` and `coq-lsp.sentencePrevious` commands will
 try to move the cursor one Coq sentence forward / backwards. These
-commands are bound by default to `Alt + P` / `Alt + N` (`Cmd` on
+commands are bound by default to `Alt + N` / `Alt + P` (`Cmd` on
 MacOS).
 
 ### Incremental proof edition