Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(make): remove old update-maxpods instruction from Makefile #5717

Merged
merged 2 commits into from
Sep 21, 2022
Merged

feat(make): remove old update-maxpods instruction from Makefile #5717

merged 2 commits into from
Sep 21, 2022

Conversation

Gearheads
Copy link
Contributor

Signed-off-by: Casale, Robert Robert.Casale@fmr.com

Description

This change will remove the no longer relevant make instruction update-maxpods.

Fixes #5691

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Gearheads
feat(make): remove old update-maxpods instruction from Makefile
496078a 
Signed-off-by: Casale, Robert <Robert.Casale@fmr.com>
github-actions[bot]
github-actions bot reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Gearheads 馃憢 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

cPu1
cPu1 approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Thanks.

@cPu1 cPu1 added area/tech-debt Leftover improvements in code, testing and building skip-release-notes Causes PR not to show in release notes labels Sep 21, 2022
@cPu1 cPu1 enabled auto-merge (squash) September 21, 2022 05:48
@cPu1 cPu1 disabled auto-merge September 21, 2022 09:54
@cPu1 cPu1 enabled auto-merge (squash) September 21, 2022 09:55
@cPu1
Copy link
Collaborator

cPu1 commented Sep 21, 2022

@Gearheads, can you rebase your branch?

@Gearheads
Copy link
Contributor Author

@Gearheads, can you rebase your branch?

yes, of course. 馃槃

@Himangini Himangini added skip-release-notes Causes PR not to show in release notes and removed skip-release-notes Causes PR not to show in release notes labels Sep 21, 2022
@cPu1 cPu1 merged commit 07d2f09 into eksctl-io:main Sep 21, 2022
@Gearheads Gearheads deleted the feat/5691-remove-update-maxpods branch September 21, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@cPu1 cPu1 cPu1 approved these changes

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Remove update-maxpods from Makefile
4 participants
@Gearheads @cPu1 @TiberiuGC @Himangini