Disallow IRSA config if addon has existing pod identity associations #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPu1
force-pushed
the
addon-podidentity-update
branch
from
8ede538
to
f2b9816
Compare
a-hilaly
approved these changes
Jun 3, 2024
| @@ -77,7 +77,7 @@ func (a *Manager) Update(ctx context.Context, addon *api.Addon, podIdentityIAMUp | |||
| } | |||
|
|
|||
| var deleteServiceAccountIAMResources []string | |||
| if len(summary.PodIdentityAssociations) > 0 && !addon.UseDefaultPodIdentityAssociations { | |||
| if len(summary.PodIdentityAssociations) > 0 && !addon.UseDefaultPodIdentityAssociations && !a.clusterConfig.AddonsConfig.AutoApplyPodIdentityAssociations { | |||
| if addon.PodIdentityAssociations == nil { | |||
There was a problem hiding this comment.
qq/non-blocking: What's the reason behind using an array pointer here? (PodIdentityAssociations *[]PodIdentityAssociation
There was a problem hiding this comment.
To remove pod identity associations from an addon, a user needs to explicitly set this field to the empty slice. A pointer is used to distinguish between an unspecified field and an empty slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disallows setting IRSA config if addon has existing pod identity associations.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く