ci: fix/refactor labeler workflow #3921
Conversation
- use more reliable 'elastic' org membership test for triage, etc. labels - bypass 'action-add-labels' action to avoid another dep
|
|
||
| - name: Add community and triage labels | ||
| if: steps.checkUserMember.outputs.isTeamMember != 'true' && steps.checkUserMember.outputs.isExcluded != 'true' | ||
| uses: actions-ecosystem/action-add-labels@v1 | ||
| if: contains(steps.is_elastic_member.outputs.result, 'false') && github.actor != 'dependabot[bot]' |
There was a problem hiding this comment.
Did you omit @apmmachine for a reason?
There was a problem hiding this comment.
I am copying what apm-agent-java is doing, e.g.: https://github.com/elastic/apm-agent-java/blob/main/.github/workflows/labeler.yml#L33
Do we use apmmachine for creating issues or PRs? I don't see any: https://github.com/elastic/apm-agent-nodejs/issues?q=author%3A%40apmmachine+
There was a problem hiding this comment.
We are still using it for updatecli workflows.
I think you need to remove the @ in the search.
https://github.com/elastic/apm-agent-nodejs/issues?q=author%3Aapmmachine+ shows the last PR in january.
There was a problem hiding this comment.
Thanks.
Presumably apm-agent-java will have the same issue, then.
There was a problem hiding this comment.
@reakaleek Oh, actually, @apmmachine is a member of "elastic", so we don't need to explicitly handle excluding github.actor === 'apmmachine' in this test.
- use more reliable 'elastic' org membership test for triage, etc. labels - bypass 'action-add-labels' action to avoid another dep - drop agent-nodejs label that we no longer require for use in GH projects Fixes: elastic#3884
Fixes: #3884
The
actions/github-script@v7usage is from apm-agent-java.The dropping
agent-nodejslabel adding is pending on team discussion (https://elastic.slack.com/archives/C9A6ANR5Y/p1710809441508399).