Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][7.1] Remove arbitrary python expressions #2595

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Aug 19, 2019

For elastic/docs#1083. A few more problems that weren't showing up on the local build.

In Asciidoctor, the old python expressions with or all evaluate to true. This PR updates them to ifdef or ifndef directives.

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll work! I don't think you need to change the single test lines but the others make sense to me. I think it is right to merge this if you are super sure you aren't going to want to sync beats again.

docs/copied-from-beats/command-reference.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit 4beaa18 into elastic:7.1 Aug 20, 2019
@bmorelli25 bmorelli25 deleted the 7.1-fields-fix branch August 20, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants