Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemtest: ensure unique package policy names #6599

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

axw
Copy link
Member

@axw axw commented Nov 14, 2021

Motivation/summary

systemtest.TestTailSampling has been failing with errors like:

2021/11/12 05:31:37 Container is ready id: d7064c092de5 image: elastic-agent-systemtest:8.1.0-49c447b0-SNAPSHOT
    kibana.go:141: 
        	Error Trace:	kibana.go:141
        	            				fleet_test.go:104
        	            				sampling_test.go:69
        	Error:      	Received unexpected error:
        	            	There is already a package with the same name
        	Test:       	TestTailSampling

Initially we thought this was flakiness in our tests, then thought maybe it was a concurrency issue in CI. Actually, it's due to a functional change in Fleet: with elastic/kibana#115212 package policy names must not be globally unique, not just unique within their agent policy.

We now ensure package policy names we generate are globally unique by including the agent policy name.

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Documentation has been updated

How to test these changes

N/A

Related issues

None

@axw axw added backport-7.16 Automated backport with mergify to the 7.16 branch backport-8.0 Automated backport with mergify labels Nov 14, 2021
@axw axw enabled auto-merge (squash) November 14, 2021 02:46
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-14T02:17:45.833+0000

  • Duration: 41 min 29 sec

  • Commit: 8130863

Test stats 🧪

Test Results
Failed 0
Passed 6036
Skipped 19
Total 6055

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@axw axw merged commit b060ae6 into elastic:master Nov 14, 2021
mergify bot pushed a commit that referenced this pull request Nov 14, 2021
mergify bot pushed a commit that referenced this pull request Nov 14, 2021
@axw axw deleted the systemtest-unique-packagepolicyname branch November 14, 2021 03:02
axw added a commit that referenced this pull request Nov 14, 2021
(cherry picked from commit b060ae6)

Co-authored-by: Andrew Wilkins <axw@elastic.co>
axw added a commit that referenced this pull request Nov 14, 2021
(cherry picked from commit b060ae6)

Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.16 Automated backport with mergify to the 7.16 branch backport-8.0 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants