Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate expected user agent fields #14190

Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 22, 2019

User agent plugin seems to have changed, and some expected
fields are different. Regenerate expected fields in golden files.

See #14179 and elastic/elasticsearch#48318 for more details.

@jsoriano jsoriano requested a review from a team as a code owner October 22, 2019 15:11
@jsoriano jsoriano self-assigned this Oct 22, 2019
@jsoriano
Copy link
Member Author

jenkins, test this again please

@ycombinator
Copy link
Contributor

Travis CI is green. Jenkins CI failures are unrelated. Merging...

@ycombinator ycombinator merged commit 6acc229 into elastic:master Oct 22, 2019
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 22, 2019
urso pushed a commit to urso/beats that referenced this pull request Oct 30, 2019
@kaiyan-sheng kaiyan-sheng added the needs_backport PR is waiting to be backported to other branches. label Oct 30, 2019
@jsoriano
Copy link
Member Author

For the record, backport of this (or equivalent regeneration of expected outputs) to 7.x will be only needed if elastic/elasticsearch#47807 is backported to ES 7.x.

@kaiyan-sheng kaiyan-sheng added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Nov 24, 2019
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
* Regenerate expected user agent fields

* Regenerate files of x-pack modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat review Team:Integrations Label for the Integrations team :Testing v7.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants