Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Upgrade node to latest LTS #40038

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[Heartbeat] Upgrade node to latest LTS #40038

merged 2 commits into from
Jun 27, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Jun 27, 2024 •
edited
Loading

Proposed commit message

Upgrade node to latest LTS v18.20.3.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@emilioalvap emilioalvap added Team:obs-ds-hosted-services Label for the Observability Hosted Services team cleanup labels Jun 27, 2024
@emilioalvap emilioalvap requested a review from a team June 27, 2024 10:06
@emilioalvap emilioalvap requested a review from a team as a code owner June 27, 2024 10:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@emilioalvap emilioalvap added the backport-v8.14.0 Automated backport with mergify label Jun 27, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 27, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

vigneshshanmugam
vigneshshanmugam approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we have to test the --prod flag, Should not be a problem given all of our deps are already intact. But worth testing it once we have it merged.

@emilioalvap emilioalvap merged commit 9143458 into elastic:main Jun 27, 2024
123 checks passed
mergify bot pushed a commit that referenced this pull request Jun 27, 2024
@emilioalvap @mergify
[Heartbeat] Upgrade node to latest LTS (#40038)
ad71d4f 
* [Heartbeat] Upgrade node to latest LTS

* Add changelog

(cherry picked from commit 9143458)
@mergify mergify bot mentioned this pull request Jun 27, 2024
Merged
5 tasks
emilioalvap added a commit that referenced this pull request Jun 28, 2024
@mergify @emilioalvap
[Heartbeat] Upgrade node to latest LTS (#40038) (#40046)
e16b5e2 
* [Heartbeat] Upgrade node to latest LTS

* Add changelog

(cherry picked from commit 9143458)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
@emilioalvap emilioalvap mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

@cmacknz cmacknz cmacknz approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.14.0 Automated backport with mergify cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emilioalvap @elasticmachine @axw @cmacknz @vigneshshanmugam @pierrehilbert