Enable CM integration tests #9625
Conversation
ph
added
:Testing
review
and removed
review
in progress
|
We can't merge it yet, the 7.0 snapshot doesn't contains the fix |
|
The reenabled tests seem to be broken on Travis. |
ph
added
needs_backport
ph
force-pushed
the
fix/revert-disable-cm
branch
from
c1c0a8f
to
0d2c37e
Compare
|
@urso I've removed the |
| c := defaultConfig() | ||
| v, _ := c.Blacklist.Patterns["output"] | ||
| assert.Equal(t, "console|file", v) | ||
| } |
There was a problem hiding this comment.
Just a sanity check to make sure we do not changes the default.
ph
changed the title
|
I think this PR elastic/kibana#27717 might impact how we create the test data in the integration suite. |
|
The failing tests are unrelated and fixed in master |
ph
force-pushed
the
fix/revert-disable-cm
branch
from
c0e7bbe
to
35d4931
Compare
|
I didn't merge this, I was able to make it fails periodically, works fine from time to time on travis, works always on local machine. I have added debug statements and I know that something is wrong with the enroll token. I think its either that when we call the Kibana API it fails to create the token or the system is not stable enough when we do the call and we do not track any errors states.. I am adding a more robust test. |
|
I've added log statement to this PR to get the kibana status error, I've also marked it as in progress so we do not merge it. It appear that we hit a bug on the kibana side. |
ph
force-pushed
the
fix/revert-disable-cm
branch
from
190897c
to
9abfe4e
Compare
ph
force-pushed
the
fix/revert-disable-cm
branch
from
9abfe4e
to
a6827e4
Compare
|
Rebased and checking if we get a more meaningful error with elastic/kibana#28541 in Kibana. |
ph
force-pushed
the
fix/revert-disable-cm
branch
from
e3bed57
to
73df636
Compare
A few things broke the integration tests, change in response and also now Kibana also blacklist some elements. I have removed the blacklisted integration tests, theses are tested using unit tests, because kibana will not return anything that is blacklisted. I've moved the integration tests away from using the file output because it its blacklisted, instead we now use the Elasticsearch output to do the assertions.
ph
force-pushed
the
fix/revert-disable-cm
branch
from
73df636
to
0cdce55
Compare
|
So I was able to get a few run green with the integration test, so I've removed the debug and squash everything up. |
A few things broke the integration tests, change in response and also now Kibana also blacklist some elements. I have removed the blacklisted integration tests, theses are tested using unit tests, because kibana will not return anything that is blacklisted. I've moved the integration tests away from using the file output because it its blacklisted, instead we now use the Elasticsearch output to do the assertions. (cherry picked from commit e46c773)
ph
added
v6.6.0
and removed
needs_backport
A few things broke the integration tests, change in response and also now Kibana also blacklist some elements. I have removed the blacklisted integration tests, theses are tested using unit tests, because kibana will not return anything that is blacklisted. I've moved the integration tests away from using the file output because it its blacklisted, instead we now use the Elasticsearch output to do the assertions. (cherry picked from commit e46c773)
A few things broke the integration tests, change in response and also
now Kibana also blacklist some elements.
I have removed the blacklisted integration tests, theses are tested
using unit tests, because kibana will not return anything that is
blacklisted.
I've moved the integration tests away from using the file output because
it its blacklisted, instead we now use the Elasticsearch output to do
the assertions.
Fixes: #9597