Asciidoctor: Fix raw xslt opts #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My previous work on raw xslt opts added extra `'`s around every variable. This broke all kinds of stuff like chunking and headers and, well, almost everything! This fixes that and makes that `--verbose` printing of commands a little more clear.
|
Escaping is seriously the hardest problem in computer science. |
ddillinger
approved these changes
Jan 7, 2019
|
Thanks for reviewing @ddillinger! |
Closed
bmorelli25
pushed a commit
to bmorelli25/docs
that referenced
this pull request
Feb 15, 2019
My previous work on raw xslt opts added extra `'`s around every variable. This broke all kinds of stuff like chunking and headers and, well, almost everything! This fixes that and makes that `--verbose` printing of commands a little more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous work on raw xslt opts added extra
's around everyvariable. This broke all kinds of stuff like chunking and headers and,
well, almost everything! This fixes that and makes that
--verboseprinting of commands a little more clear.