Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoctor: Copy admonition images #604

Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 12, 2019

Copies the images used by admonitions like WARNING and NOTE and the
change admonitions like coming.

Copies the images used by admonitions like `WARNING` and `NOTE` and the
change admonitions like `coming`.
Copy link

@ddillinger ddillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As best I can tell this is indeed cromulent code :)

@nik9000
Copy link
Member Author

nik9000 commented Feb 13, 2019

Thanks for the review @ddillinger!

@nik9000 nik9000 merged commit 09629f7 into elastic:master Feb 13, 2019
@nik9000 nik9000 mentioned this pull request Feb 13, 2019
nik9000 added a commit that referenced this pull request Feb 15, 2019
Copies the images used by admonitions like `WARNING` and `NOTE` and the
change admonitions like `coming`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants