Switch the perl client docs to asciidoctor #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the perl client docs to asciidoctor. `html_diff` says asciidoctor produces exactly the same output modulo new lines.
nik9000
commented
Mar 7, 2019
| @@ -120,7 +120,7 @@ alias docbldnet='$GIT_HOME/docs/build_docs.pl --doc $GIT_HOME/elasticsearch-net/ | |||
|
|
|||
| alias docbldphp='$GIT_HOME/docs/build_docs.pl --doc $GIT_HOME/elasticsearch-php/docs/index.asciidoc' | |||
|
|
|||
| alias docbldepl='$GIT_HOME/docs/build_docs.pl --doc $GIT_HOME/elasticsearch/docs/perl/index.asciidoc --single 1' | |||
| alias docbldepl='$GIT_HOME/docs/build_docs --asciidoctor --doc $GIT_HOME/elasticsearch/docs/perl/index.asciidoc --single' | |||
There was a problem hiding this comment.
The 1 doesn't actually work with build_docs. Since no one has complained I'm going to assume that is ok and just drop it. The 1 didn't do anything - just specifying --single does the trick.
lcawl
approved these changes
Mar 7, 2019
|
Thanks for reviewing @lcawl! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the perl client docs to asciidoctor.
html_diffsaysasciidoctor produces exactly the same output modulo new lines.