Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the APM Agent for .NET to Asciidoctor #705

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 12, 2019

Switches the APM Agent for .NET's docs from the no-longer-maintained
AsciiDoc project to Asciidoctor. The only difference between the html
output is spacing which the browser ignores.

Switches the APM Agent for .NET's docs from the no-longer-maintained
AsciiDoc project to Asciidoctor. The only difference between the html
output is spacing which the browser ignores.
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Also tested locally, it works fine.
👍

@nik9000 nik9000 merged commit d224c0a into elastic:master Mar 12, 2019
@nik9000
Copy link
Member Author

nik9000 commented Mar 12, 2019

Thanks for reviewing @gregkalapos and @bmorelli25!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants