Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch APM Agent for RUM JavaScript #714

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 13, 2019

Switches the docs build core for the APM Agent for RUM JavaScript from
the no-longer-supported AsciiDoc to the actively maintained Asciidoctor.
The generated HTML is the same modulo whitespace which the browser
ignores.

Switches the docs build core for the APM Agent for RUM JavaScript from
the no-longer-supported AsciiDoc to the actively maintained Asciidoctor.
The generated HTML is the same modulo whitespace which the browser
ignores.
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nik9000 nik9000 merged commit 3603810 into elastic:master Mar 14, 2019
@nik9000
Copy link
Member Author

nik9000 commented Mar 14, 2019

Thanks for reviewing @bmorelli25 and @jahtalab ! When you next build the book please use the new command line options described in the aliases file. Thanks again!

@nik9000 nik9000 mentioned this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants