Switch APM Overview to Asciidoctor #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the core of the docs build for the APM overview from the unmaintained AsciiDoc to the actively maintained AsciiDoctor project. It is marginally faster to build as well. The HTML output is the same modulo some spacing differences and one real change to the tables on the `install-and-run` page. The first element on the table gets the "heading" formatting. Like this: ``` - <a class="ulink" href="https://www.elastic.co/guide/en/apm/agent/js-base/current/intro.html" target="_top"> - Introduction - </a> + <span class="strong strong"> + <strong> + <a class="ulink" href="https://www.elastic.co/guide/en/apm/agent/js-base/current/intro.html" target="_top"> + Introduction + </a> + </strong> + </span> ``` This is worth looking into. It isn't what we want but I can see *why* Asciidoctor does it.
Closed
|
Ohh, actually, this is perfect! I added attributes that should add a header to that table: https://github.com/elastic/apm-server/blame/master/docs/guide/install-and-run.asciidoc#L99 |
Co-Authored-By: nik9000 <nik9000@gmail.com>
bmorelli25
approved these changes
Mar 20, 2019
Strong strong! |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the core of the docs build for the APM overview from the
unmaintained AsciiDoc to the actively maintained AsciiDoctor project. It
is marginally faster to build as well. The HTML output is the same
modulo some spacing differences and one real change to the tables on the
install-and-runpage. The first element on the table gets the"heading" formatting. Like this:
This is worth looking into. It isn't what we want but I can see why
Asciidoctor does it.