Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch legacy graph docs to Asciidoctor #814

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 12, 2019

Switches the core of the docs build for the legacy graph docs from the
unmaintained AsciiDoc project to the actively maintained Asciidoctor
project.

Switches the core of the docs build for the legacy graph docs from the
unmaintained AsciiDoc project to the actively maintained Asciidoctor
project.
@nik9000 nik9000 requested review from lcawl and jrodewig April 12, 2019 16:34
@nik9000
Copy link
Member Author

nik9000 commented Apr 12, 2019

Here is the diff:

graph-limitations.html

- AsciiDoc
+ Asciidoctor
@@ -587,11 +587,15 @@
              a different field
             </em>
            </span>
-           held in another type or index. A good example of where that might be useful is if an ip address found in the ‘remote_host` field of an index called "weblogs20160101" might want to be followed up by looking for this value in the
+           held in another type or index. A good example of where that might be useful is if an ip address found in the
+           <code class="literal">
+            remote_host
+           </code>
+           field of an index called "weblogs20160101" might want to be followed up by looking for this value in the
            <code class="literal">
             ip_address
            </code>
-           field of an index called "knownthreats". For the Graph API to support this, extra mapping would be required to understand that the weblogs’
+           field of an index called "knownthreats". For the Graph API to support this, extra mapping would be required to understand that the weblogs'
            <code class="literal">
             remote_host
            </code>

These seem ok. We use some odd quotes in some of our docs.

@nik9000 nik9000 marked this pull request as ready for review April 12, 2019 17:36
@nik9000 nik9000 mentioned this pull request Apr 15, 2019
@nik9000 nik9000 merged commit 88abee2 into elastic:master Apr 17, 2019
@nik9000
Copy link
Member Author

nik9000 commented Apr 17, 2019

Hearing no objections and given that this is a net-0 change to the rendered docs I've merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant