Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example components to the changelog fragment #145

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jun 21, 2023

People are often confused about how to use the component field. I've added some examples to help clarify this. The component field will mostly be used to identify the affected Beat when this tool is used in Beats.

@cmacknz cmacknz self-assigned this Jun 21, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T16:27:09.527+0000

  • Duration: 5 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 85
Skipped 0
Total 85

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Collaborator

@pierrehilbert pierrehilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo in your fragment file to correct: you put two dots before yaml.

@cmacknz
Copy link
Member Author

cmacknz commented Jun 21, 2023

Odd because I used the changelog tool itself to generate that file.

@cmacknz
Copy link
Member Author

cmacknz commented Jun 21, 2023

Ah if you add a period to the end of the changelog fragment like ./elastic-agent-changelog-tool new "Add example components in fragement." it includes it in the filename.

@cmacknz cmacknz merged commit acf9e18 into elastic:main Jun 21, 2023
@cmacknz cmacknz deleted the add-example-components branch June 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants