-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to buildkite #158
Conversation
/test |
buildkite test it |
1 similar comment
buildkite test it |
buildkite test it |
This reverts commit 2ae5cdf.
catalog-info.yaml
Outdated
env: | ||
ELASTIC_PR_COMMENTS_ENABLED: 'true' | ||
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true' | ||
SLACK_NOTIFICATIONS_CHANNEL: '#elastic-agent-control-plane' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to decide which channel to use instead
.buildkite/scripts/release.sh
Outdated
with_goreleaser | ||
|
||
echo "--- Goreleaser Release" | ||
goreleaser release --snapshot #TODO remove snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this TODO something that should remove before merging?
.buildkite/scripts/test.sh
Outdated
awk '{gsub("---", "----"); print }' tests-report.txt | ||
|
||
# Create Junit report for junit annotation plugin | ||
go-junit-report > junit-report.xml < tests-report.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was discussing this with @pazone today, I think it would be better to move the go-junit-report
into its own step in the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will run in a separate container then.... but i changed it
No description provided.