-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add livetest makefile command #78
Conversation
There is a way to do this without the flag: by deleting the YAML test file My reason for not adding a flag is because even if it's a really cool Go feature is easy to get confused by it and Given that in any case we need to provide guidance in the docs about this, I would provide guidance on the file removal way, maybe through a |
@endorama I've added a makefile command that just deletes the testdata file in the In the original implementation I don't think the flag would have been an issue, given that it was optional. If the flag was not provided, the test would run using the recorded testdata. The advantage of the |
68c1117
to
e1836e7
Compare
e1836e7
to
3d49922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a developer only change I would not include the changelog fragment.
Apart from that, lets merge this!
The
live
flag added in this test is used to get a live response from the GitHub API.This might prove useful as sometimes the responses can change over time.
Let me know if this implementation is alright @endorama and I will continue writing it and update the rest of the tests with it.