Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fragment summary autocompletion from title #94

Merged
merged 6 commits into from
Sep 19, 2022

Conversation

lucian-ioan
Copy link
Collaborator

Closes #84

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T11:48:42.869+0000

  • Duration: 3 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 70
Skipped 0
Total 70

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama
Copy link
Member

Would be better to use text/template instead of byte manipulation.

@lucian-ioan
Copy link
Collaborator Author

@endorama Let me know if you prefer writing the fragment in the Template function instead and getting rid of the buffer.

@endorama
Copy link
Member

@LucianPy I think it's ok like this, thanks!

@lucian-ioan lucian-ioan merged commit 44ede0b into elastic:main Sep 19, 2022
endorama added a commit that referenced this pull request Sep 19, 2022
@lucian-ioan lucian-ioan deleted the autocomplete-summary-from-title branch October 26, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically fill Changelog Fragment summary from new command argument
3 participants