-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add EDOT colletor kube-stack Helm values #5822
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
``` | ||
$ helm repo add open-telemetry https://open-telemetry.github.io/opentelemetry-helm-charts | ||
$ helm repo update | ||
$ helm upgrade --install --namespace opentelemetry-operator-system opentelemetry-kube-stack open-telemetry/opentelemetry-kube-stack --values ./resources/kubernetes/operator/helm/values.yaml --version 0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would update the path to values.yaml relative to what will be in this folder
So not ./resources/kubernetes/operator/helm/values.yaml
rather /deploy/helm ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I think I would prefer to keep it relative to the README's directory: 89cd2a6
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
nit: Dont have strong preference, wondering if we need the extra subfolder kube-stack. |
Not a strong opinion neither, maybe having the extra directory will be easier for us to add extra Helm Charts. Open to any suggestion |
@eedugon Adding you as reviewer in case you want to share your feedback about the values path or anything related to the PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogercoll while I am still reading through this PR, I have the following questions on top of my head:
- since this is another "deployment artifact" of elastic-agent an integration test should be part of this PR that tests at least that the agent pod is getting deployment and get healthy; is there any that I missed?!
- how do you plan to keep the agent version updated in the values.yaml?!
Totally agree, is there any example I can look into?
I was thinking on Renovate. Not very familiar with the elastic-agent code, I will take look |
You can look here I believe that with a few minor changes you can definitely test the EDOT helm chart
To be honest I am not super familiar with Renovate, maybe now we could the reverse of the above and you give me a PR/code link so I can have a look and get more familiar with it? 🙂 |
https://github.com/open-telemetry/opentelemetry-demo/blob/main/renovate.json5#L113 Is there any other tool already available to do that? How PRs like #4592 are created? |
defaultCRConfig: | ||
image: | ||
repository: "docker.elastic.co/beats/elastic-agent" | ||
tag: "8.16.0-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To @pkoutsovasilis' point, I'd either comment this out or put a placeholder here, and assume implicitly that the agent version from the git revision applies. Otherwise we'll need to keep updating it via tooling on every active branch, and it's going to be very annoying. Even in this PR, it should be 8.17.0 - there's already a separate branch for 8.16.
Not sure how much of a problem this will be for Kibana. Maybe they can just fill the stack version in here?
Quality Gate passedIssues Measures |
What does this PR do?
Adds a sample configuration to be used when deploying the OpenTelemetry Kube Stack Helm Chart.
Why is it important?
This configuration will be used during the Elastic K8s Onboarding experience starting from 8.16. The EDOT collector is the central piece of the whole Chart deployment, if we provide an invalid image or collector's configuration, the deployment will fail.
The file is currently hosted in the elastic/opentelemetry repository, but this files needs to be versioned as it is tied to the stack's (elastic-agent) release version. The elastic/opentelemetry repository does not have a release strategy (neither backport) yet, thus, and being the EDOT collector the backbone of the deployment, we think that hosting this file in this repository would be more appropriate.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
No
How to test this PR locally
Added a README.md file an installation section.
Related issues
Questions to ask yourself