Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle discontinuous bar series crosshair interactions #221

Closed
1 of 3 tasks
emmacunningham opened this issue May 29, 2019 · 1 comment · Fixed by #346
Closed
1 of 3 tasks

Handle discontinuous bar series crosshair interactions #221

emmacunningham opened this issue May 29, 2019 · 1 comment · Fixed by #346
Labels
discuss To be discussed enhancement New feature or request :interactions Interactions related issue released Issue released publicly

Comments

@emmacunningham
Copy link
Contributor

In #200, we use d3's bisectLeft to calculate the value returned by invertWithStep; this helps solve the scenarios where we have discontinuous data in a line or area series, but also now means that for a bar series with discontinuous data, it will snap the band highlighter to the nearest x value with a datum defined. This can look quite odd for a bar series with a huge gap between x values as below:

bar_chart_hover

(With the previous implementation, hovering over an area with no data in a bar serious would highlight the empty band with no selected data.)

Is your feature request related to a problem? Please describe.
It would be nice to either bring back the previous way of handling these empty zones or handle the hover state such that if the cursor is not within a minimum range near a data point, either we show the band highlighter with no data or there is no hover interaction at all.

Describe the solution you'd like
Would like to discuss the options for how to handle these cases before beginning on implementatiion 😄

Describe alternatives you've considered

Additional context

Kibana Cross Issues

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@emmacunningham emmacunningham added enhancement New feature or request discuss To be discussed :interactions Interactions related issue labels May 29, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Aug 25, 2019
@markov00
fix(scales): bisect correctly on continuous scales
629ef13 
This commit fix the wrong behaviour of the current invertWithStep implementation. It also fix the
behaviour of cursor sync between charts with only lines and charts with only bars and empty
intervals.

fix elastic#227, fix elastic#221
@markov00 markov00 mentioned this issue Aug 25, 2019
Merged
4 tasks
markov00 added a commit that referenced this issue Aug 26, 2019
@markov00
fix(scales): bisect correctly on continuous scales (#346)
5112208 
This commit fix the wrong behaviour of the current invertWithStep implementation. It also fix the behaviour of cursor sync between charts with only lines and charts with only bars and empty intervals.
It also removes the annotation dependency on ticks

fix #227, fix #221
markov00 pushed a commit that referenced this issue Aug 26, 2019
@semantic-release-bot
chore(release): 10.3.1 [skip ci]
d47de40 
## [10.3.1](v10.3.0...v10.3.1) (2019-08-26)

### Bug Fixes

* **scales:** bisect correctly on continuous scales ([#346](#346)) ([5112208](5112208)), closes [#227](#227) [#221](#221)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 10.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 26, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 10.3.1 [skip ci]
b0a8818 
## [10.3.1](elastic/elastic-charts@v10.3.0...v10.3.1) (2019-08-26)

### Bug Fixes

* **scales:** bisect correctly on continuous scales ([opensearch-project#346](elastic/elastic-charts#346)) ([0bb5b19](elastic/elastic-charts@0bb5b19)), closes [opensearch-project#227](elastic/elastic-charts#227) [opensearch-project#221](elastic/elastic-charts#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss To be discussed enhancement New feature or request :interactions Interactions related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(scales): bisect correctly on continuous scales markov00/elastic-charts
2 participants
@emmacunningham @markov00