Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tick lines #330

Closed
cchaos opened this issue Aug 19, 2019 · 1 comment · Fixed by #374
Closed

Remove tick lines #330

cchaos opened this issue Aug 19, 2019 · 1 comment · Fixed by #374
Assignees
@nickofthyme
Labels
:axis Axis related issue bug Something isn't working released Issue released publicly

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 19, 2019

Describe the bug
The tick lines that are visible between the tick label and the grid adds lots of noise to the tick labels. Instead we should be relying on the grid to mark out the values across the whole chart so users can actually follow a line to the correct value.

Expected behavior
I tried removing them by setting theme.tickLineStyle.strokeWidth = 0. While this does make them disappear, there is still a lot of extra space between the tick label and the axis line leftover from where the tick line should be.

image

Either,
A. just get rid of the idea of tick lines
B. make sure we can fully remove theme via the theme

Version (please complete the following information):

  • Elastic Charts: 9.0.4
@cchaos cchaos added bug Something isn't working :axis Axis related issue labels Aug 19, 2019
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Sep 12, 2019
@nickofthyme
feat(axis): add visibility to tick style
0f5d2b9 
Add visibility propterty to tickLineStyle in Theme. (default: false)

BREAKING CHANGE: `theme.axes.tickLineStyle.visible` is now required (default base is false)

closes elastic#330
@nickofthyme nickofthyme mentioned this issue Sep 12, 2019
Merged
3 tasks
@nickofthyme nickofthyme self-assigned this Sep 13, 2019
nickofthyme added a commit that referenced this issue Sep 19, 2019
@nickofthyme
feat(axis): add visibility to tick style (#374)
265a6bb 
Add visibility property to `tickLineStyle` in `Theme`. (default: `false`)

BREAKING CHANGE: `theme.axes.tickLineStyle.visible` is now required (default base is false)

closes #330
markov00 pushed a commit that referenced this issue Sep 19, 2019
@semantic-release-bot
chore(release): 13.0.0 [skip ci]
e1b0cd6 
# [13.0.0](v12.1.0...v13.0.0) (2019-09-19)

### Features

* **axis:** add visibility to tick style ([#374](#374)) ([265a6bb](265a6bb)), closes [#330](#330)

### BREAKING CHANGES

* **axis:** `theme.axes.tickLineStyle.visible` is now required (default base is false)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 19, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 13.0.0 [skip ci]
741481b 
# [13.0.0](elastic/elastic-charts@v12.1.0...v13.0.0) (2019-09-19)

### Features

* **axis:** add visibility to tick style ([opensearch-project#374](elastic/elastic-charts#374)) ([29e9e1e](elastic/elastic-charts@29e9e1e)), closes [opensearch-project#330](elastic/elastic-charts#330)

### BREAKING CHANGES

* **axis:** `theme.axes.tickLineStyle.visible` is now required (default base is false)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
:axis Axis related issue bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(axis): add visibility to tick style nickofthyme/elastic-charts
3 participants
@cchaos @markov00 @nickofthyme