Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend should resize when series titles change #367

Closed
3 tasks done
nickofthyme opened this issue Sep 5, 2019 · 4 comments · Fixed by #441
Closed
3 tasks done

Legend should resize when series titles change #367

nickofthyme opened this issue Sep 5, 2019 · 4 comments · Fixed by #441
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 5, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
When configuring a visualization in Kibana the chart legend with render a narrow legend then create longer series labels and create a squashed legend.

Screen Recording 2019-09-05 at 10 45 AM

Describe the solution you'd like
The legend size should resize, preferably animate, when legend series labels change.

Describe alternatives you've considered
None really come to mind.

Kibana Cross Issues
Add any Kibana related issues/feature requests here.

Additional Context

Fixed by a full-page refresh
Screen Recording 2019-10-24 at 03 50 PM

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@nickofthyme nickofthyme added enhancement New feature or request :legend Legend related issue labels Sep 5, 2019
@markov00
Copy link
Member

markov00 commented Oct 3, 2019 •
edited
Loading

what about adding a feature to manually resize the legend? an handle can be dragged to resize it 😬

@nickofthyme
Copy link
Collaborator Author

like a method on the Chart (i.e. chartRef.updateLegnedSize())?

@markov00
Copy link
Member

markov00 commented Oct 9, 2019

I think that should be done automatically by the chart itself. If one of the legend item changed it's value, than the legend should resize

@nickofthyme nickofthyme mentioned this issue Oct 24, 2019
Merged
3 tasks
nickofthyme added a commit that referenced this issue Oct 25, 2019
@nickofthyme
fix: initial legend sizing issue (#441)
64b9f83 
Fix legend sizing issue with no initial legend and dynamic legend data.

closes #367
markov00 pushed a commit that referenced this issue Oct 25, 2019
@semantic-release-bot
chore(release): 13.5.9 [skip ci]
7f1ac5e 
## [13.5.9](v13.5.8...v13.5.9) (2019-10-25)

### Bug Fixes

* initial legend sizing issue ([#441](#441)) ([64b9f83](64b9f83)), closes [#367](#367)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 13.5.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 25, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 13.5.9 [skip ci]
103b88a 
## [13.5.9](elastic/elastic-charts@v13.5.8...v13.5.9) (2019-10-25)

### Bug Fixes

* initial legend sizing issue ([opensearch-project#441](elastic/elastic-charts#441)) ([52dc393](elastic/elastic-charts@52dc393)), closes [#367](elastic/elastic-charts#367)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request :legend Legend related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: legend sizing issue with no initial legend nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme