Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prop to coalesce duplicate Axes #368

Closed
3 tasks done
nickofthyme opened this issue Sep 5, 2019 · 1 comment · Fixed by #370
Closed
3 tasks done

Prop to coalesce duplicate Axes #368

nickofthyme opened this issue Sep 5, 2019 · 1 comment · Fixed by #370
Assignees
@nickofthyme
Labels
:axis Axis related issue enhancement New feature or request kibana cross issue Has a Kibana issue counterpart released Issue released publicly :TSVB Kibana TSVB related

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Sep 5, 2019 •
edited by markov00
Loading

Is your feature request related to a problem? Please describe.
Allow hideDuplicateAxes prop to remove duplicate axes.

Axis should be hidden if all of the following conditions are true:

  • The first and last tick labels (with applied tickFormat) match
  • The length of the ticks match
  • The titles match, can be both undefined
  • The position on the spec match (i.e. top, right, bottom, left)

Describe the solution you'd like
hideDuplicateAxes prop to remove duplicate axes.

Describe alternatives you've considered
Check axis domains manually

Kibana Cross Issues

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@nickofthyme nickofthyme added enhancement New feature or request :axis Axis related issue labels Sep 5, 2019
@nickofthyme nickofthyme changed the title Allow props to coalesce duplicate Y-Axis Prop to coalesce duplicate Y-Axis Sep 5, 2019
@nickofthyme nickofthyme changed the title Prop to coalesce duplicate Y-Axis Prop to coalesce duplicate Axes Sep 10, 2019
@nickofthyme nickofthyme added the :TSVB Kibana TSVB related label Sep 10, 2019
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this issue Sep 10, 2019
@nickofthyme
feat(axis): option to hide duplicate axes
37808ff 
* Option to hide axes based on tick labels, position and title.
* Refactor axes render function.

closes elastic#368
@nickofthyme nickofthyme mentioned this issue Sep 10, 2019
Merged
5 tasks
@nickofthyme nickofthyme self-assigned this Sep 13, 2019
nickofthyme added a commit that referenced this issue Sep 19, 2019
@nickofthyme
feat(axis): option to hide duplicate axes (#370)
ada2ddc 
* Option to hide axes based on tick labels, position and title.
* Refactor axes render function.

closes #368
markov00 pushed a commit that referenced this issue Sep 19, 2019
@semantic-release-bot
chore(release): 12.1.0 [skip ci]
53a0fe0 
# [12.1.0](v12.0.2...v12.1.0) (2019-09-19)

### Features

* **axis:** option to hide duplicate axes ([#370](#370)) ([ada2ddc](ada2ddc)), closes [#368](#368)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 19, 2019
@markov00 markov00 added the kibana cross issue Has a Kibana issue counterpart label Sep 6, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 12.1.0 [skip ci]
36891f1 
# [12.1.0](elastic/elastic-charts@v12.0.2...v12.1.0) (2019-09-19)

### Features

* **axis:** option to hide duplicate axes ([opensearch-project#370](elastic/elastic-charts#370)) ([4381734](elastic/elastic-charts@4381734)), closes [opensearch-project#368](elastic/elastic-charts#368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
:axis Axis related issue enhancement New feature or request kibana cross issue Has a Kibana issue counterpart released Issue released publicly :TSVB Kibana TSVB related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(axis): option to hide duplicate axes nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme