Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual regression tests #77

Closed
4 tasks
markov00 opened this issue Feb 22, 2019 · 1 comment · Fixed by #394
Closed
4 tasks

Visual regression tests #77

markov00 opened this issue Feb 22, 2019 · 1 comment · Fixed by #394
Assignees
@nickofthyme
Labels
released Issue released publicly :test Missing or to be fixed test

Comments

@markov00
Copy link
Member

markov00 commented Feb 22, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Add visual regression tests with image snapshot comparisons.
This can be applied to:

  • storybook stories
  • custom tests

Describe the solution you'd like
Evaluate the following:

  • custom implementation with jest-puppeteer
  • storyshots-puppeteer
  • percy or other SaaS tools
  • loki

Requirements:

  • single snapshot comparisons
  • comparisons between different renderings canvas === svg ? ok : fail

References:
@markov00 markov00 added enhancement New feature or request meta ...meta issue :test Missing or to be fixed test labels Feb 22, 2019
@markov00 markov00 self-assigned this Feb 22, 2019
@markov00 markov00 reopened this Feb 28, 2019
@markov00 markov00 mentioned this issue Feb 28, 2019
Closed
93 tasks
@markov00 markov00 added this to the 7.1 milestone Feb 28, 2019
@markov00 markov00 removed meta ...meta issue enhancement New feature or request labels Feb 28, 2019
@markov00 markov00 modified the milestones: Kibana 7.2, Kibana 7.3 May 22, 2019
@markov00 markov00 mentioned this issue Aug 28, 2019
Merged
4 tasks
@nickofthyme nickofthyme assigned nickofthyme and unassigned markov00 Sep 26, 2019
@nickofthyme nickofthyme mentioned this issue Sep 26, 2019
Merged
3 tasks
nickofthyme added a commit that referenced this issue Oct 10, 2019
@nickofthyme
test: visual regression (#394)
59c39bd 
Add basic jest screenshot config. Upgrade typescript, jest and related devDependencies.

Add baseline and relevant `[test]` screenshot tests.

Add devDependencies
- jest-image-snapshot
- puppeteer
- jest-puppeteer
- seedrandom
- jest-puppeteer-docker

Upgraded devDependencies:
- jest
- typescript
- @typescript-eslint/eslint-plugin
- @typescript-eslint/parser
- ts-jest
- ts-loader

closes #77
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 13.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

Labels
released Issue released publicly :test Missing or to be fixed test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: visual regression nickofthyme/elastic-charts
2 participants
@markov00 @nickofthyme