Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tick label padding to axis spec #94

Closed
3 tasks done
emmacunningham opened this issue Mar 7, 2019 · 1 comment · Fixed by #217 or elastic/kibana#40751
Closed
3 tasks done

Add tick label padding to axis spec #94

emmacunningham opened this issue Mar 7, 2019 · 1 comment · Fixed by #217 or elastic/kibana#40751
Assignees
@rshen91
Labels
:axis Axis related issue enhancement New feature or request released Issue released publicly

Comments

@emmacunningham
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We add a small amount of default padding (1px) to axis tick labels to help with discrepancies in browser canvas text measurement. Users might want to themselves be able to adjust the amount of padding for a tick label, which is what is proposed here.

Describe the solution you'd like
Add tick label padding to the axis spec and use this to adjust the computed bounding box dimensions for a tick label.

Describe alternatives you've considered
n/a

Additional context
n/a

Kibana Cross Issues
n/a

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@emmacunningham emmacunningham added enhancement New feature or request :axis Axis related issue labels Mar 7, 2019
@emmacunningham emmacunningham mentioned this issue Mar 7, 2019
Merged
2 tasks
@rshen91 rshen91 mentioned this issue Apr 17, 2019
Closed
2 tasks
@rshen91 rshen91 mentioned this issue May 22, 2019
Merged
2 tasks
rshen91 added a commit that referenced this issue Jul 3, 2019
@rshen91
feat(axis): add tickLabelPadding prop (#217)
4d40936 
* add tickLabelPadding prop
* add theme tickLabelPadding
* suppress canvas padding manipulation
* specify tickLabelPadding from axisSpec or axisConfig
* isolate spec and theme in tickLabelPadding story
* add AxisStyle interface

#94
markov00 pushed a commit that referenced this issue Jul 3, 2019
@semantic-release-bot
chore(release): 7.1.0 [skip ci]
3c291a2 
# [7.1.0](v7.0.2...v7.1.0) (2019-07-03)

### Features

* **axis:** add tickLabelPadding prop ([#217](#217)) ([4d40936](4d40936)), closes [#94](#94)
@markov00
Copy link
Member

markov00 commented Jul 3, 2019

🎉 This issue has been resolved in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 3, 2019
@markov00 markov00 mentioned this issue Jul 10, 2019
Merged
1 task
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 7.1.0 [skip ci]
28f7815 
# [7.1.0](elastic/elastic-charts@v7.0.2...v7.1.0) (2019-07-03)

### Features

* **axis:** add tickLabelPadding prop ([opensearch-project#217](elastic/elastic-charts#217)) ([080df95](elastic/elastic-charts@080df95)), closes [opensearch-project#94](elastic/elastic-charts#94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
:axis Axis related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Milestone
No milestone
3 participants
@emmacunningham @markov00 @rshen91