fix(axis_title): remove whitespace with empty axis title #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whitespace left from an undefined title is removed from the computation of the axis dimension, removing the unneccessary whitespace occupied by an empty title label fix elastic#225
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 97.81% 97.81% +<.01%
==========================================
Files 35 35
Lines 2563 2564 +1
Branches 559 573 +14
==========================================
+ Hits 2507 2508 +1
Misses 49 49
Partials 7 7
Continue to review full report at Codecov.
|
|
@markov00 Thank you very much for the update! Btw your coverage reports looks very nice! |
emmacunningham
approved these changes
Jun 4, 2019
|
🎉 This PR is included in version 4.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [4.2.7](elastic/elastic-charts@v4.2.6...v4.2.7) (2019-06-05) ### Bug Fixes * **axis_title:** remove whitespace with empty axis title ([opensearch-project#226](elastic/elastic-charts#226)) ([52a2d49](elastic/elastic-charts@52a2d49)), closes [opensearch-project#225](elastic/elastic-charts#225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #225
This PR remove the whitespace left from an undefined
titleaxis spec.The whitespace is kept if the
titleprop is any string also an empty one. Only if it's undefined, the occupied space is removed.The
Styling->margins and paddingsstorybook story is updated with this change. Switch the show label on axis title checkboxs to add or remove the axis title from the chart configurationChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)