fix(last_value): compute last value for non stacked series

[markov00]

Summary

Fix an error introduced in #250 where the last value on the legend was undefined for non stacked series.

When using the stack percentage mode, the data values are computed on a percentage scale. As we want to display the percent value and not the original value when displaying a tooltip, I've changed the place where the lastValue value is captured: from the original dataset to the formatted one.

The commit fix the the fact that the last value was computed only for stacked series.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
• [ ] This was checked for cross-browser compatibility, including a check against IE11
• [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
• Unit tests were updated or added to match the most common scenarios
• Each commit follows the convention

[codecov-io]

Codecov Report

Merging #261 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   97.84%   97.85%   +<.01%     
==========================================
  Files          36       36              
  Lines        2693     2698       +5     
  Branches      607      609       +2     
==========================================
+ Hits         2635     2640       +5     
  Misses         51       51              
  Partials        7        7

Impacted Files	Coverage Δ
src/lib/series/series.ts	100% <ø> (ø)	⬆️
src/state/utils.ts	96.58% <100%> (+0.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e727605...a79104a. Read the comment docs.

[emmacunningham]

Looks like something weird is going on when the series is clustered but also stackAsPercentage={true}:

[markov00]

Looks like something weird is going on when the series is clustered but also stackAsPercentage={true}:

Are you referring to the legend showing 600 % and 200 % ? I will update the storybook for that, the wrong thing here is that I'm multipling by 100 the value on the tickFormatter either for the stacked as percentage mode and for non stacked one

[emmacunningham]

Looks like something weird is going on when the series is clustered but also stackAsPercentage={true}:

Are you referring to the legend showing 600 % and 200 % ? I will update the storybook for that, the wrong thing here is that I'm multipling by 100 the value on the tickFormatter either for the stacked as percentage mode and for non stacked one

Yes, the legend display value is what I was referring to. I wasn't exactly sure how we want to handle this since clustered + stackAsPercentage isn't an ideal configuration, but I see now how that's just a Storybook configuration thing that can be easily solved :D

[emmacunningham]

besides the storybook issue, things working locally & code LGTM

[nickofthyme]

Tested locally, LGTM.

[markov00]

🎉 This PR is included in version 7.2.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀