Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale_continuous): use bisect value iff gap in data #328

Closed
wants to merge 2 commits into from

Conversation

nickofthyme
Copy link
Collaborator

Summary

#227

Revive fix for bad hover. #230

Before

Screen Recording 2019-08-19 at 02 35 PM

After

Screen Recording 2019-08-19 at 02 31 PM

Checklist

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #328 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   98.05%   98.05%   +<.01%     
==========================================
  Files          38       38              
  Lines        2726     2728       +2     
  Branches      643      644       +1     
==========================================
+ Hits         2673     2675       +2     
  Misses         48       48              
  Partials        5        5
Impacted Files Coverage Δ
src/utils/scales/scale_continuous.ts 94.26% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577a034...30afa37. Read the comment docs.

@nickofthyme
Copy link
Collaborator Author

Need to fix 👇

http://localhost:9001/?path=/story/grids--basic

Screen Recording 2019-08-19 at 02 41 PM

@markov00 markov00 added the wip work in progress label Aug 20, 2019
@nickofthyme nickofthyme added :styling Styling related issue bug Something isn't working labels Aug 21, 2019
@markov00
Copy link
Member

close in favour of #346

@markov00 markov00 closed this Aug 25, 2019
@nickofthyme nickofthyme deleted the fix/bisect-value branch August 26, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :styling Styling related issue wip work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants