ci: add console errors to smoke tests #705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
force-pushed
the
smoke-test-logs
branch
from
bd67e37
to
e5a456a
Compare
markov00
reviewed
Jun 12, 2020
browsers/browsers.test.ts
Outdated
Comment on lines
65
to
66
| console.log('ERRRORS BROWSER', JSON.stringify(entries)); | ||
| console.log('ERRRORS CLIENT', JSON.stringify(entries2)); |
There was a problem hiding this comment.
Aaaaaaaaagaaaaaiiiiinnnn thhhhhiiiiss. ccccccccouldddd beeeeee fffffffiiiiiixxxxxeddd :D
There was a problem hiding this comment.
lol I'm trying to log the console errors from the webdriver on the browser tests. Any ideas? This doesn't log anything.
There was a problem hiding this comment.
I think the logging API has not been implemented in the IE driver
There was a problem hiding this comment.
and since this will be sunsetted very soon I think we should not care that much
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add console errors to smoke tests to help identify the issue. Currently the test just fails and doesn't output the
console.errors.