Docs: Drop subtitle in Asciidoctor #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use Asciidoctor to build the docs for the elasticsearch-net repo it sees the `:` in the title of the book as a delimiter for a subtitle. This is probably a nice feature, but we actually intend the title of the book to have a `:` in it. The simple work around is to use a different character for the delimiter. This change does that.
russcam
approved these changes
Apr 16, 2019
|
I'll pull in now to the relevant branches |
|
Thanks!
…On Tue, Apr 16, 2019, 19:39 Russ Cam ***@***.***> wrote:
I'll pull in now to the relevant branches
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3676 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLokcRMtyTVZnvYdXkPPhyGg_0fSjuks5vhl9BgaJpZM4cy5iW>
.
|
russcam
pushed a commit
that referenced
this pull request
Apr 17, 2019
When we use Asciidoctor to build the docs for the elasticsearch-net repo it sees the `:` in the title of the book as a delimiter for a subtitle. This is probably a nice feature, but we actually intend the title of the book to have a `:` in it. The simple work around is to use a different character for the delimiter. This change does that. (cherry picked from commit e24fdc0)
russcam
pushed a commit
that referenced
this pull request
Apr 17, 2019
When we use Asciidoctor to build the docs for the elasticsearch-net repo it sees the `:` in the title of the book as a delimiter for a subtitle. This is probably a nice feature, but we actually intend the title of the book to have a `:` in it. The simple work around is to use a different character for the delimiter. This change does that. (cherry picked from commit e24fdc0)
russcam
pushed a commit
that referenced
this pull request
Apr 17, 2019
When we use Asciidoctor to build the docs for the elasticsearch-net repo it sees the `:` in the title of the book as a delimiter for a subtitle. This is probably a nice feature, but we actually intend the title of the book to have a `:` in it. The simple work around is to use a different character for the delimiter. This change does that. (cherry picked from commit e24fdc0)
russcam
pushed a commit
that referenced
this pull request
Apr 17, 2019
When we use Asciidoctor to build the docs for the elasticsearch-net repo it sees the `:` in the title of the book as a delimiter for a subtitle. This is probably a nice feature, but we actually intend the title of the book to have a `:` in it. The simple work around is to use a different character for the delimiter. This change does that. (cherry picked from commit e24fdc0)
russcam
pushed a commit
that referenced
this pull request
Apr 17, 2019
When we use Asciidoctor to build the docs for the elasticsearch-net repo it sees the `:` in the title of the book as a delimiter for a subtitle. This is probably a nice feature, but we actually intend the title of the book to have a `:` in it. The simple work around is to use a different character for the delimiter. This change does that. (cherry picked from commit e24fdc0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use Asciidoctor to build the docs for the elasticsearch-net repo
it sees the
:in the title of the book as a delimiter for a subtitle.This is probably a nice feature, but we actually intend the title of the
book to have a
:in it. The simple work around is to use a differentcharacter for the delimiter. This change does that.