Fix failing transform tests and support dates_as_epoch_millis #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing due to a change in the transform API which now prefers ISO dates, rather than epoch milliseconds for dates. This resulted in a serialisation failure. This commit addresses that by conditionally producing the requests based on the version of ES being tested, so that a property of the appropriate type is used for deserialisation of the preview. This also adds support for the now dates_as_epoch_millis setting which allows the original epoch millisecond format to be returned for ES 7.11 requests, when the option is true.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 28, 2020
Tests were failing due to a change in the transform API which now prefers ISO dates, rather than epoch milliseconds for dates. This resulted in a serialisation failure. This commit addresses that by conditionally producing the requests based on the version of ES being tested, so that a property of the appropriate type is used for deserialisation of the preview. This also adds support for the now dates_as_epoch_millis setting which allows the original epoch millisecond format to be returned for ES 7.11 requests, when the option is true.
This comment has been minimized.
This comment has been minimized.
Mpdreamz
pushed a commit
that referenced
this pull request
Dec 28, 2020
Tests were failing due to a change in the transform API which now prefers ISO dates, rather than epoch milliseconds for dates. This resulted in a serialisation failure. This commit addresses that by conditionally producing the requests based on the version of ES being tested, so that a property of the appropriate type is used for deserialisation of the preview. This also adds support for the now dates_as_epoch_millis setting which allows the original epoch millisecond format to be returned for ES 7.11 requests, when the option is true. (cherry picked from commit 7994d6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing due to a change in the transform API which now prefers ISO dates, rather than epoch milliseconds for dates. This resulted in a serialisation failure.
This commit addresses that by conditionally producing the requests based on the version of ES being tested, so that a property of the appropriate type is used for deserialisation of the preview.
This also adds support for the now dates_as_epoch_millis setting which allows the original epoch millisecond format to be returned for ES 7.11 requests, when the option is true.
Fixes #5185
Contributes to #5198