Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrized mapper should not fail on silently unsupported parameters #59359

Closed
romseygeek opened this issue Jul 10, 2020 · 1 comment · Fixed by #59381
Closed

Parametrized mapper should not fail on silently unsupported parameters #59359

romseygeek opened this issue Jul 10, 2020 · 1 comment · Fixed by #59381
Assignees
@romseygeek
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v7.9.0 v8.0.0-alpha1

Comments

@romseygeek
Copy link
Contributor

#58663 converted the boolean and binary field mappers to a new format, but in the process removed support for the previously silently ignored index parameter. This breaks existing mappings in 7.9. We should instead issue a warning when we detect those parameters on indexes created before 8x, and only fail on indexes created afterwards.
@romseygeek romseygeek added :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.9.0 labels Jul 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 10, 2020
@romseygeek romseygeek self-assigned this Jul 10, 2020
This was referenced Jul 10, 2020
Merged
Merged
romseygeek added a commit that referenced this issue Jul 13, 2020
@romseygeek
Continue to accept unused 'universal' params in <8.0 indexes (#59381)
3363048 
We have a number of parameters which are universally parsed by almost all
mappers, whether or not they make sense. Migrating the binary and boolean
mappers to the new style of declaring their parameters explicitly has meant
that these universal parameters stopped being accepted, which would break
existing mappings.

This commit adds some extra logic to ParametrizedFieldMapper that checks
for the existence of these universal parameters, and issues a warning on
7x indexes if it finds them. Indexes created in 8.0 and beyond will throw an
error.

Fixes #59359
romseygeek added a commit that referenced this issue Jul 13, 2020
@romseygeek
Continue to accept unused 'universal' params in <8.0 indexes (#59381)
c810a4a 
We have a number of parameters which are universally parsed by almost all
mappers, whether or not they make sense. Migrating the binary and boolean
mappers to the new style of declaring their parameters explicitly has meant
that these universal parameters stopped being accepted, which would break
existing mappings.

This commit adds some extra logic to ParametrizedFieldMapper that checks
for the existence of these universal parameters, and issues a warning on
7x indexes if it finds them. Indexes created in 8.0 and beyond will throw an
error.

Fixes #59359
@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romseygeek romseygeek

Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Continue to accept unused 'universal' params in <8.0 indexes romseygeek/elasticsearch
4 participants
@javanna @jakelandis @romseygeek @elasticmachine